-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Class Parameters, Parent Containment, and Updated Touch Controls #8
Open
BSchafer01
wants to merge
7
commits into
carlfranklin:master
Choose a base branch
from
BSchafer01:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added class parameters for the slider panels and Absolute panel
Updated the logic of the Absolute Panel to be contained within a parent container/div While updating the logic, I fixed the touch controls to output int pixels to remove an uncaught error
Added a functionality to define the starting width/height of a panel based on the parent container's width/height. Wrapped some cascading values to handle vertical/horizontal panel widths and heights. Modified the integration tests to capture the new menu item and the "approximate golden ratio sample" page
I just added functionality to allow users to define their width/height units (either percent, px, or rem). If the user specifies percent they will define the initial percentage in the "TopPanelHeight" or "LeftPanelStartingWidth" parameters. |
Any chance this gets pulled into the master? |
Sorry! I completely missed this. I'll check it out today.
…On Wed, Feb 9, 2022 at 1:37 PM Leon Bost ***@***.***> wrote:
Any chance this gets pulled into the master?
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALK4DFVJVMN4XPQKLVBIFTU2JUZTANCNFSM47M4NLLQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@carlfranklin This PR seems really valuable on top of your great work. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class Parameters
LeftClassString
,RightClassString
,TopClassString
,BottomClassString
,SliderClassString
, andOverrideSliderStyle
parameters to the vertical panel and horizontal panel components.background-color
andcursor
styles to adefaultSlider
class in the isolated CSS of the horizontal and vertical panel componentsOverrideSliderStyle
totrue
and then the user can define the background and cursor to what they would likeClassString
parameter to the absolute panel componentParent Containment
ParentContained
parameter to the absolute panel. The user must set this totrue
if they want the panel controls to be contained to it's parent div.AbsolutePanel
, once it finds this it will get the calculated values of its parent elementUpdated Touch Controls
Added Sample Views and Test Cases
Let me know if there's anything you would like to see differently.