Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml configuration #78

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Yaml configuration #78

merged 14 commits into from
Oct 9, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Sep 18, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6d70730

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

endersonmaia
endersonmaia requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of changes, are you planning to split those in smaller commits or PRs?

I was just exploring the build process with mke2fs but there's a lot more to review and test, and this is going to be hard with such a big PR.

apps/cli/src/commands/build.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/build.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/build.ts Outdated Show resolved Hide resolved
@tuler
Copy link
Member Author

tuler commented Oct 9, 2024

Maybe we can merge this, and retry to organize the PR?

@tuler tuler marked this pull request as ready for review October 9, 2024 21:22
@tuler tuler merged commit 8686626 into feature/config-file Oct 9, 2024
2 checks passed
@tuler tuler deleted the feature/config-file-yaml branch October 9, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endersonmaia endersonmaia Awaiting requested review from endersonmaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuler @endersonmaia