-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test of builders #88
Conversation
|
Coverage Report for ./apps/cli
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some changes in the test case descriptions, didn't do for every case, but hope you get the idea.
integration tests
379fe2d
to
cf56072
Compare
increase test timeout
creating empty dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, but will suggest some improvements for other PRs.
The fallback message should be a WARN
message with less details.
Instead of error executing 'xgenext2fs', falling back to docker execution using image 'cartesi/sdk:0.11.0'
we cold shw something like:
WARN: xgenext2fs not found, using
cartesi/sdk container image
For better builder code coverage, we should also include tests for sqfs
type filesystems.
docker build with target
done |
yeah, interpreting the errors raised by xgenext2fs cli is kind of hard |
skip failing test
integration tests for builders