Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Create a common base contract for portals and relays #131

Closed
4 tasks
guidanoli opened this issue Jul 3, 2023 · 0 comments · Fixed by #67
Closed
4 tasks

Create a common base contract for portals and relays #131

guidanoli opened this issue Jul 3, 2023 · 0 comments · Fixed by #67
Assignees
@guidanoli
Labels
onchain Related to the onchain code refactor
Milestone
1.0.0

Comments

@guidanoli
Copy link
Contributor

📚 Context

As previously discussed in #33, portals and relays have isomorphic interfaces.
We decided to name this common interface "Input Relay".
However, currently portals and relays have different base interfaces.

✔️ Solution

We should remove the "Portal" and "Relay" interfaces, and add an "Input Relay" interface. The same goes for the base implementations.

📈 Subtasks

  • Add IInputRelay.sol and InputRelay.sol
  • Make portals and relays use IInputRelay.sol and InputRelay.sol
  • Remove IPortal.sol and Portal.sol
  • Remove IRelay.sol and Relay.sol
@guidanoli guidanoli added refactor onchain Related to the onchain code labels Jul 3, 2023
@guidanoli guidanoli added this to the 1.0.0 milestone Jul 3, 2023
@guidanoli guidanoli self-assigned this Jul 3, 2023
@guidanoli guidanoli linked a pull request Jul 3, 2023 that will close this issue
Add input relay base contract #67
Merged
@guidanoli guidanoli mentioned this issue Jul 3, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@guidanoli guidanoli

Labels
onchain Related to the onchain code refactor
Projects
Rollups Unit
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add input relay base contract cartesi/rollups
1 participant
@guidanoli