This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Add input relay base contract #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ZzzzHui
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Do you think the folder structure under test/foundry should be consistent as under the contracts?
Also, I think there are quite a lot of files under the inputs folder, which makes it difficult to figure out where to start reading. Do you think we should create new folders under inputs for those renamed files? We could consider a structure like:
- inputs
- input relay
- address relay
- portals
|
@ZzzzHui After some thought, I think I agree with you on this. I will revert the moving of contracts. :-) |
guidanoli
force-pushed
the
feature/add-input-relay-base-contract
branch
from
2ea6729
to
727782c
Compare
|
Rebased and reverted moving of contracts. :-) |
guidanoli
force-pushed
the
feature/add-input-relay-base-contract
branch
from
727782c
to
7082820
Compare
|
Fixed some paths. :-) |
|
👍 Just need to rebase the branch |
guidanoli
force-pushed
the
feature/add-input-relay-base-contract
branch
from
7082820
to
0824521
Compare
|
Rebased 🙌 |
ZzzzHui
previously approved these changes
Jun 2, 2023
|
This PR is ready to merge |
guidanoli
force-pushed
the
feature/add-input-relay-base-contract
branch
from
0824521
to
682bd36
Compare
|
Rebased, and ran |
ZzzzHui
approved these changes
Jun 26, 2023
pedroargento
approved these changes
Jun 30, 2023
* Make portals and relays inherit `InputRelay` * Make portals and relays interfaces inherit `IInputRelay`
guidanoli
force-pushed
the
feature/add-input-relay-base-contract
branch
from
682bd36
to
b747ccc
Compare
|
Rebased. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
contracts/inputscalledInputRelayInputRelayPortalandRelayRelated issues
Closes #131.
Footnotes
and associated interface(s) ↩ ↩2 ↩3