Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Import host-server-manager and rename it to host-runner #112

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Import host-server-manager and rename it to host-runner #112

merged 5 commits into from
Jun 28, 2023

Conversation

gligneul
Copy link
Contributor

Close #23

@gligneul gligneul requested a review from a team June 15, 2023 20:28
@gligneul gligneul self-assigned this Jun 15, 2023
@gligneul gligneul force-pushed the feature/host-runer branch 4 times, most recently from 3244690 to 12f406b Compare June 21, 2023 19:32
@gligneul gligneul marked this pull request as ready for review June 22, 2023 13:24
torives
torives reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@torives torives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for the sensible commits, made the review a lot easier. Eager to see the future improvements to the host-runner once this gets merged!

Just found some minor details and typos. Also, there's a "r" missing in the branch's name 😅

offchain/host-runner/README.md Outdated Show resolved Hide resolved
offchain/host-runner/README.md Outdated Show resolved Hide resolved
offchain/host-runner/README.md Outdated Show resolved Hide resolved
offchain/host-runner/README.md Outdated Show resolved Hide resolved
offchain/host-runner/tests/common/config.rs Outdated Show resolved Hide resolved
offchain/host-runner/src/grpc/server_manager.rs Outdated Show resolved Hide resolved
torives
torives previously approved these changes Jun 23, 2023
View reviewed changes
@gligneul gligneul mentioned this pull request Jun 23, 2023
Closed
@gligneul gligneul force-pushed the feature/host-runer branch 2 times, most recently from 092e917 to 446de1c Compare June 26, 2023 12:24
@gligneul gligneul changed the base branch from main to fix/offchain-ci June 26, 2023 12:24
Base automatically changed from fix/offchain-ci to main June 26, 2023 21:15
@gligneul
refactor(offchain): import rollup-http-client
3b10dfd 
The original code history is available at the machine emulator tools
repository (https://github.com/cartesi/machine-emulator-tools/).
@gligneul
refactor(offchain): adapt rollup-http-client to rollup workspace
7257087
@gligneul
refactor(offchain): import host-server-manager
a03bca7 
The original history can be found at the previous repository.
https://github.com/cartesi/host-server-manager
@gligneul
refactor(offchain): transform host-server-manager into host-runner
12e2094 
- Rename the host-server-manager to host-runner.
- Remove redundant files from the host-runner crate.
- Remove dates from copyright.
- Replace env-logger with tracing.
- Replace structopt with clap.
- Use grpc-interfaces crate in host-runner.
- Add host-runner to the offchain workspace Cargo.toml.
- Add host-runner to the offchain Dockerfile.
- Add host-runner to the Github CI.
@gligneul
test(host-runner): fix race condition in tests
f31c4d2 
The race condition happened because the finish function in the
finish_advance_state function did not wait for the result.
@gligneul gligneul requested a review from a team June 27, 2023 12:51
@gligneul gligneul merged commit f31c4d2 into main Jun 28, 2023
@gligneul gligneul deleted the feature/host-runer branch June 28, 2023 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@torives torives torives approved these changes

@fmoura fmoura fmoura approved these changes

@renan061 renan061 Awaiting requested review from renan061

Assignees

@gligneul gligneul

Labels
None yet
Projects
Node Unit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate host-server-manager to rollups repository
4 participants
@gligneul @fmoura @renan061 @torives