This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gligneul
force-pushed
the
feature/update-dependencies
branch
from
August 11, 2023 21:09
bc08615
to
43fa9ea
Compare
Before releasing, we still need to:
|
gligneul
force-pushed
the
feature/update-dependencies
branch
4 times, most recently
from
August 16, 2023 18:48
f0c9187
to
0724a33
Compare
guidanoli
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of stylizing code-like names with backticks.
As a bonus, this removes the need to escape some underscores.
InvalidClaimIndex
rollups-cli
RPC_URL
InputBox
InputRelay
inboxInputIndex
inputIndex
CREATE2
OutputValidityProof
host-server-manager
host-runner
rollups-deployments
@cartesi/util
ConsensusCreated
Authority
IInputBox
grpc_health_check
polygon_mumbai
bsc_testnet
iotex_testnet
Also, I prefer on-chain and off-chain over "onchain" and "offchain".
gligneul
force-pushed
the
feature/update-dependencies
branch
from
August 17, 2023 13:54
0724a33
to
4474899
Compare
gligneul
force-pushed
the
feature/update-dependencies
branch
from
August 17, 2023 14:00
4474899
to
6c58ef1
Compare
gligneul
force-pushed
the
feature/update-dependencies
branch
3 times, most recently
from
August 17, 2023 17:04
d435c6d
to
ed8c82f
Compare
This is a new error thrown by the server-manager.
gligneul
force-pushed
the
feature/update-dependencies
branch
from
August 17, 2023 17:09
ed8c82f
to
4c6a1ed
Compare
guidanoli
reviewed
Aug 17, 2023
gligneul
force-pushed
the
feature/update-dependencies
branch
from
August 17, 2023 17:46
4c6a1ed
to
2666b28
Compare
tuler
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
guidanoli
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8