Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Conversation

guidanoli
Copy link
Contributor

@guidanoli guidanoli commented May 31, 2023

This also fixes the Rollups CLI.

Closes cartesi/rollups-contracts#35

@guidanoli guidanoli added refactor onchain Related to the onchain code labels May 31, 2023
@guidanoli guidanoli requested a review from tuler May 31, 2023 13:27
@guidanoli guidanoli self-assigned this May 31, 2023
@tuler
Copy link
Member

tuler commented May 31, 2023

This change has impact on rollups-cli. I think it should be handled in a single PR to make sure everything works.

@guidanoli
Copy link
Contributor Author

@tuler You're right. I will make this PR be the last in a link of PRs starting from #64.

@guidanoli guidanoli force-pushed the feature/rm-authority-history-deployment branch from 2e600d6 to 287f648 Compare June 16, 2023 13:08
@guidanoli guidanoli changed the base branch from main to feature/authority-history-pair-factory June 16, 2023 13:08
@guidanoli guidanoli marked this pull request as draft June 16, 2023 13:09
@guidanoli guidanoli force-pushed the feature/rm-authority-history-deployment branch from f13ba8b to 4612bd7 Compare June 16, 2023 17:39
@guidanoli guidanoli marked this pull request as ready for review June 16, 2023 17:40
@guidanoli guidanoli linked an issue Jun 19, 2023 that may be closed by this pull request
6 tasks
@guidanoli guidanoli force-pushed the feature/authority-history-pair-factory branch from ca82572 to 4beb261 Compare July 11, 2023 13:43
@guidanoli guidanoli force-pushed the feature/rm-authority-history-deployment branch from 2342be0 to 19712f5 Compare July 11, 2023 13:47
@guidanoli
Copy link
Contributor Author

Rebased.

@guidanoli guidanoli force-pushed the feature/authority-history-pair-factory branch 2 times, most recently from f3f6ec9 to 0462cc2 Compare July 19, 2023 15:49
@guidanoli guidanoli force-pushed the feature/rm-authority-history-deployment branch from 19712f5 to 289a2b7 Compare July 20, 2023 02:44
@guidanoli
Copy link
Contributor Author

Rebased and reorganized commits.

@guidanoli guidanoli force-pushed the feature/authority-history-pair-factory branch from 0462cc2 to dfd4d60 Compare July 20, 2023 17:36
* Removed `Authority` address as default option for `--consensusAddress`
* Removed `authority` exported variable from `src/connect.ts`

BREAKING CHANGE: require `--consensusAddress <addr>`
BREAKING CHANGE: command "create" no longer exists
BREAKING CHANGE: remove deployment script and deployment files of
`History` and `Authority`.
@guidanoli guidanoli force-pushed the feature/rm-authority-history-deployment branch from 289a2b7 to 2677d3a Compare July 20, 2023 17:50
@guidanoli
Copy link
Contributor Author

This PR has been migrated to cartesi/rollups-contracts#36.

@guidanoli guidanoli closed this Aug 26, 2023
@guidanoli guidanoli deleted the feature/rm-authority-history-deployment branch August 28, 2023 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
onchain Related to the onchain code refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Authority and History deployment Adjust Rollups CLI to use Authority factories
2 participants