Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytt: document openapi validation attributes, mapped to named validations #739

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

peschmae
Copy link
Contributor

Documentation for ytt#899

Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for carvel ready!

Name Link
🔨 Latest commit 964281c
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/662390967136fa00086a93a9
😎 Deploy Preview https://deploy-preview-739--carvel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, added some comments, but generally looks good

site/content/ytt/docs/develop/how-to-export-schema.md Outdated Show resolved Hide resolved
site/content/ytt/docs/develop/how-to-export-schema.md Outdated Show resolved Hide resolved
site/content/ytt/docs/develop/how-to-export-schema.md Outdated Show resolved Hide resolved
site/content/ytt/docs/develop/how-to-export-schema.md Outdated Show resolved Hide resolved
site/content/ytt/docs/develop/how-to-export-schema.md Outdated Show resolved Hide resolved
Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
@peschmae
Copy link
Contributor Author

Updated documentation with a hint that validations aren't exported when a when= condition is set on a validation.

Added minItems/minProperties attribute documentation for array and objects added in carvel-dev/ytt@43dee5f

…minProperties mapping for array and objects

Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 57aab3a into carvel-dev:develop Sep 13, 2024
5 checks passed
@peschmae peschmae deleted the feat/openapi-validations branch September 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants