Making CRDAppFactory an interface #1498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Sethiya <yashsethiya97@gmail.com>
sethiyash
force-pushed
the
1494-app-factory-interface
branch
from
eaa0ae7 to
d46919f
Compare
sethiyash
commented
Feb 26, 2024
| ) | ||
|
|
||
| // ICRDAppFactory interface for CRDAppFactory | ||
| type ICRDAppFactory interface { |
There was a problem hiding this comment.
ICRDAppFactory Maybe not a good name let me know if you have some better suggestions.
|
@jorgemoralespou, Is this what you are looking for? |
|
Yes. Thank you for getting to this so fast. |
|
LGTM |
praveenrewar
approved these changes
Apr 8, 2024
Comment on lines
+24
to
+27
| // ICRDAppFactory interface for CRDAppFactory | ||
| type ICRDAppFactory interface { | ||
| NewCRDApp(*kcv1alpha1.App, logr.Logger) *CRDApp | ||
| } |
There was a problem hiding this comment.
Suggested change
| // ICRDAppFactory interface for CRDAppFactory | |
| type ICRDAppFactory interface { | |
| NewCRDApp(*kcv1alpha1.App, logr.Logger) *CRDApp | |
| } | |
| // CRDAppCreator interface for CRDAppFactory | |
| type CRDAppCreator interface { | |
| Create(*kcv1alpha1.App, logr.Logger) *CRDApp | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
#1494
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: