#527 - Adding structure to support maven jib build#563
Open
vishrantgupta wants to merge 10 commits intocarvel-dev:developfrom
Open
#527 - Adding structure to support maven jib build#563vishrantgupta wants to merge 10 commits intocarvel-dev:developfrom
vishrantgupta wants to merge 10 commits intocarvel-dev:developfrom
Conversation
carvel-dev#527 - Adding structure to support maven jib build
added 4 commits
October 23, 2025 00:33
vishrantgupta
had a problem deploying
to
DockerHub E2E
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Maven Jib build support to kbld, including a simple Maven “HelloWorld” fixture and a new example config to build images via mvn jib:dockerBuild.
Changes:
- Introduces a Maven/Jib builder and wires it into
BuiltImageresolution. - Adds Jib-specific config structs and a new example manifest for local Maven builds.
- Updates Go module dependencies (notably downgrading several modules).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/assets/simple-app/helloworld/src/main/java/example/HelloWorld.java | Adds a minimal Java entrypoint for a Maven/Jib build fixture. |
| test/e2e/assets/simple-app/helloworld/pom.xml | Adds a Maven project configured to build an image via Jib. |
| pkg/kbld/image/factory.go | Wires Maven/Jib builder into image factory pipeline. |
| pkg/kbld/image/built.go | Adds Maven build source handling path that runs Jib and optionally pushes. |
| pkg/kbld/config/config_jib.go | Introduces config types for Jib run options. |
| pkg/kbld/config/config.go | Adds Maven source option to the main Source config. |
| pkg/kbld/builder/maven/jib.go | Implements Maven Jib builder execution and Docker retagging. |
| pkg/kbld/builder/docker/docker.go | Adds logging for Docker inspect command execution. |
| examples/simple-app-build-local-mvn/build.yml | Adds an example kbld config using maven.run. |
| go.mod / go.sum | Updates (and downgrades) several Go dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: kbld-simple-app-build-local-bazel |
| spec: | ||
| selector: | ||
| matchLabels: | ||
| app: kbld-simple-app-build-local-bazel |
| template: | ||
| metadata: | ||
| labels: | ||
| app: kbld-simple-app-build-local-bazel |
| maven: | ||
| run: | ||
| target: helloworld | ||
| name: simple-app |
| "compile", | ||
| "jib:dockerBuild", | ||
| "-Dimage=" + targetImage, | ||
| "-Djib.allowInsecureRegistries=true", |
| "path/filepath" | ||
| ) | ||
|
|
||
| var defaultImageTag = "latest" |
|
|
||
| tag := opts.Tag | ||
| if tag == nil { | ||
| tag = &defaultImageTag |
Comment on lines
+6
to
+7
| carvel.dev/imgpkg v0.43.1 | ||
| carvel.dev/vendir v0.40.0 |
| github.com/stretchr/testify v1.10.0 | ||
| golang.org/x/sync v0.14.0 | ||
| k8s.io/apimachinery v0.32.1 | ||
| k8s.io/apimachinery v0.30.7 |
| k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect | ||
| sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for maven jib build.
Example: