Skip to content

Add Buildah support#585

Open
joaopapereira wants to merge 8 commits intocarvel-dev:developfrom
joaopapereira:buildah
Open

Add Buildah support#585
joaopapereira wants to merge 8 commits intocarvel-dev:developfrom
joaopapereira:buildah

Conversation

@joaopapereira
Copy link
Copy Markdown
Member

Based on the PR #543 from @Baenimyr with the following changes:

  • Compressed all the commits from @Baenimyr into a single one to make it easier for me to ensure DCO passes
  • Made changes to the original workflow because our builders do operations in a different order, where tagging is done afterwards and not by the builder itself

Benjamin Le Rohellec and others added 3 commits April 7, 2026 13:37
buildah : raw options
buildah : options build-arg
buildah : platforms

Build for multiple platforms.
Use a manifest in all situations because buildah can not create a manifest when a tag already exists.
buildah : publish with all tags

Manifests for buildah and podman have no digest.
Buildah pushs the manifest to all tags and TaggedImage must ignore the incomplete URL.
buildah : get the manifest digest with --digestfile
The manifest digest is written to a temporary file with the option --digestfile.
Push only to a random tag and let kbld create the other tags.

log : buildah commands

:recycle: Generate args in SourceBuildahOpts

lint : variable names

lint : comments

log : buildah show errors with the Logger

buildah : local and remote image name from configuration id and destination

Use the destination name for local storage if available.
The destination name use a special random tag.

buildah : use tag 'latest' by default

test : buildah build and push

buildah : direct pipe for stderr

Generation logs are printed in direct using stderr. Flushes mid-sentence are not well rendered through logger.

buildah : use a new manifest for each build

Using the same manifest name accumulates images. The local manifest needs a random name.

Signed-off-by: Benjamin Le Rohellec <benjamin@le-rohellec.fr>
Allow for some numbers when single digits or known port numbers to be
presented as not magic numbers

Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
- No longer push with definitive tags, keep consistent with the behavior
  of other builders and create a temporary tag to build the image. After
  that it retrieves the digest and create the needed tags.
- Fix linter problems

Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants