Open
Conversation
buildah : raw options buildah : options build-arg buildah : platforms Build for multiple platforms. Use a manifest in all situations because buildah can not create a manifest when a tag already exists. buildah : publish with all tags Manifests for buildah and podman have no digest. Buildah pushs the manifest to all tags and TaggedImage must ignore the incomplete URL. buildah : get the manifest digest with --digestfile The manifest digest is written to a temporary file with the option --digestfile. Push only to a random tag and let kbld create the other tags. log : buildah commands :recycle: Generate args in SourceBuildahOpts lint : variable names lint : comments log : buildah show errors with the Logger buildah : local and remote image name from configuration id and destination Use the destination name for local storage if available. The destination name use a special random tag. buildah : use tag 'latest' by default test : buildah build and push buildah : direct pipe for stderr Generation logs are printed in direct using stderr. Flushes mid-sentence are not well rendered through logger. buildah : use a new manifest for each build Using the same manifest name accumulates images. The local manifest needs a random name. Signed-off-by: Benjamin Le Rohellec <benjamin@le-rohellec.fr>
Allow for some numbers when single digits or known port numbers to be presented as not magic numbers Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
- No longer push with definitive tags, keep consistent with the behavior of other builders and create a temporary tag to build the image. After that it retrieves the digest and create the needed tags. - Fix linter problems Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
Signed-off-by: Joao Pereira <joaopapereira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the PR #543 from @Baenimyr with the following changes: