Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go version to 1.22.3 #914

Merged
merged 2 commits into from
May 17, 2024
Merged

Bump go version to 1.22.3 #914

merged 2 commits into from
May 17, 2024

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented May 15, 2024 •
edited
Loading

  • Bump go version to v1.22.3
    • Use go line in go.mod to define minimum patch version
  • Bump linter to 1.58
  • Fix linter issues
    • Remove deadcode linter as it's deprecated
    • Allow dot-imports as it's useful in unit tests
    • Use _ as name of unused parameters
  • Add workflow_dispatcher as an event in trivy scan workflow (to allow manually triggering a trivy scan)

@praveenrewar
Bump go version to 1.22.3
4287858 
Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
@praveenrewar
Fix linter issues
c6bffe2 
Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
joaopapereira
joaopapereira approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 8f101fd into carvel-dev:develop May 17, 2024
5 checks passed
@praveenrewar praveenrewar deleted the bump-go branch May 17, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praveenrewar @joaopapereira