Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TLS option for redis adapter creation #38

Merged
merged 5 commits into from
Dec 14, 2022
Merged

feat: add TLS option for redis adapter creation #38

merged 5 commits into from
Dec 14, 2022

Conversation

ziranl16
Copy link
Contributor

@ziranl16 ziranl16 commented Dec 13, 2022 •
edited
Loading

Fix: #36

Use the following if you use Redis with TLS option.

var clientTLSConfig tls.Config
...
a, err := NewAdapterWithOption(WithNetwork("tcp"), WithAddress("127.0.0.1:6379"), WithUsername("testAccount"), WithPassword("123456"), WithTLS(&clientTLSConfig))

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Dec 13, 2022 •
edited
Loading

Coverage Status

Coverage increased (+3.4%) to 74.268% when pulling a26b6b7 on ziranl16:feat-#36-tls-option into 0cd40e5 on casbin:master.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 13, 2022

@sujatapatnaik52 plz review

@ziranl16 ziranl16 marked this pull request as ready for review December 14, 2022 01:26
@ziranl16 ziranl16 changed the title Add TLS option for redis adapter creation feat: add TLS option for redis adapter creation Dec 14, 2022
sujatapatnaik52
sujatapatnaik52 reviewed Dec 14, 2022
View reviewed changes
hsluoyz
hsluoyz requested changes Dec 14, 2022
View reviewed changes
@hsluoyz
Copy link
Member

hsluoyz commented Dec 14, 2022

@ziranl16 also add to README

@ziranl16
Copy link
Contributor Author

@ziranl16 also add to README

done

@ziranl16 ziranl16 requested review from hsluoyz and removed request for imp2002 and tangyang9464 December 14, 2022 09:21
@ziranl16
Copy link
Contributor Author

I think the commits will automatically squash after merge, thus I will not explicitly squash them in the PR.

@hsluoyz hsluoyz merged commit 17a13a7 into casbin:master Dec 14, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujatapatnaik52 sujatapatnaik52 sujatapatnaik52 left review comments

@hsluoyz hsluoyz hsluoyz approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having tls options while creating the adapter
6 participants
@ziranl16 @casbin-bot @CLAassistant @coveralls @hsluoyz @sujatapatnaik52