Fix NULL being appended to SQL statements with no interpolations#341
Merged
rsslldnphy merged 1 commit intomainfrom Jan 31, 2026
Merged
Fix NULL being appended to SQL statements with no interpolations#341rsslldnphy merged 1 commit intomainfrom
rsslldnphy merged 1 commit intomainfrom
Conversation
rsslldnphy
force-pushed
the
undefined-fix
branch
from
cc8470c to
0aa31cb
Compare
The zip function from es-toolkit pads arrays of different lengths with undefined. Since template literals always have one more fragment than values, when there were no interpolated values, zip would pair the single fragment with undefined, which then got converted to "NULL". Extracted a processTemplateParts helper that properly handles the template literal structure by pairing each value with its preceding fragment and appending the final fragment separately. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rsslldnphy
force-pushed
the
undefined-fix
branch
from
0aa31cb to
8497ac2
Compare
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql`SELECT * FROM posts`) would have "NULL" appended to themzipfrom es-toolkit padding arrays of different lengths withundefined, which was then converted to "NULL"processTemplatePartshelper that properly handles the template literal structureTest plan
🤖 Generated with Claude Code