Add a minimum macOS version that matches the SnapshotTesting dependency #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
approved these changes
Nov 11, 2024
priip
approved these changes
Nov 11, 2024
The SnapshotTesting dependency specifies 10.15 as the minimum version. Even though this library doesn't support macOS, it's helpful to specify one so it can be consumed in mixed-platform packages. Today, if a mixed iOS/macOS package depends on AccessibilitySnapshot, SPM emits an error: "error: the library 'AccessibilitySnapshot' requires macos 10.13, but depends on the product 'SnapshotTesting' which requires macos 10.15; consider changing the library 'AccessibilitySnapshot' to require macos 10.15 or later, or the product 'SnapshotTesting' to require macos 10.13 or earlier."
jmesmith
force-pushed
the
bump-min-macos-version
branch
from
6e027b5
to
5655f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SnapshotTesting dependency specifies 10.15 as the minimum version. Even though this library doesn't support macOS, it's helpful to specify one that's compatible with its dependencies so it can be consumed in mixed-platform packages. Today, if a mixed iOS/macOS package depends on AccessibilitySnapshot, SPM emits an error: