Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gRPC connector to backfila #398

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Add a gRPC connector to backfila #398

merged 6 commits into from
Aug 29, 2024

Conversation

ThePumpingLemma
Copy link
Collaborator

No description provided.

@ThePumpingLemma ThePumpingLemma force-pushed the dgrochowski.grpc branch 6 times, most recently from 853a65f to e4e786a Compare August 29, 2024 05:34
Copy link
Collaborator

@mpawliszyn mpawliszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want the Backfila grpc service?

Otherwise I would think we would need to do more to the guice config to configure it properly?

Also what about the path that GRPC would use? Or does that no longer matter?

@@ -104,3 +104,10 @@ message CheckBackfillStatusResponse {
COMPLETE = 3;
}
}

service BackfilaService {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need this unless we want people to use GRPC to talk to Backfila as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I debated whether or not we should add this from a symmetry perspective. Don't feel strongly either way, but it would be nice to support gRPC bidirectionally in the future (since we standardized on it internally).

@ThePumpingLemma
Copy link
Collaborator Author

ThePumpingLemma commented Aug 29, 2024

I think we don't want the Backfila grpc service?

Otherwise I would think we would need to do more to the guice config to configure it properly?

Yeah, this is more aspirational currently. Not 100% sure how to wire up an additional gRPC variant in Misk.

Also what about the path that GRPC would use? Or does that no longer matter?

gRPC doesn't need paths (the path is effectively specified by the package name), we just need to specify the authority for the client.

@ThePumpingLemma ThePumpingLemma changed the title Dgrochowski.grpc Add a gRPC connector to backfila Aug 29, 2024
@ThePumpingLemma ThePumpingLemma marked this pull request as ready for review August 29, 2024 15:28
@mpawliszyn mpawliszyn merged commit 1d5e282 into master Aug 29, 2024
5 checks passed
@ThePumpingLemma ThePumpingLemma deleted the dgrochowski.grpc branch August 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants