Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DuplicateRegistrationDetector for whole graph Containers #213

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Implement DuplicateRegistrationDetector for whole graph Containers #213

wants to merge 6 commits into from

Conversation

bradfol
Copy link
Collaborator

@bradfol bradfol commented Nov 9, 2024 •
edited
Loading

Adds runtime duplicate registration detection across entire Containers to allow for whole-graph safety.

skorulis-ap
skorulis-ap approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@skorulis-ap skorulis-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Not sure how we get the Swinject changes merged in.

@bradfol bradfol changed the title Implement DuplicateDetection for whole graph Containers Implement DuplicateRegistrationDetector for whole graph Containers Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorulis-ap skorulis-ap skorulis-ap approved these changes

@jmesmith jmesmith Awaiting requested review from jmesmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradfol @skorulis-ap