Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for installing via Bazel #71

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Add support for installing via Bazel #71

merged 1 commit into from
Jan 20, 2024

Conversation

NickEntin
Copy link
Collaborator

  • Adds support for installing Stagehand
  • Adds support for installing StagehandTesting when using iOSSnapshotTestCase as the snapshotting engine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luispadron Is this supposed to get checked in? Not sure why it was generated here, but didn't seem to be for the other repos.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You maybe built before adding the version file for Bazel. It's enabled by default in Bazel 7.

I wouldn't add it until we're on 7 since the format isn't stable in 6.x.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yeah that could be. Sounds good, I'll remove it for now. 👍

Copy link
Collaborator

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@luispadron
Copy link
Collaborator

I'll work on getting SnapshotTesting into the registry so we can add it here and to the other repos

* Adds support for installing `Stagehand` via Bazel
* Adds support for installing `StagehandTesting` via Bazel _when using `iOSSnapshotTestCase` as the snapshotting engine_. Support for `SnapshotTesting` is currently blocked.
@NickEntin NickEntin merged commit d4cc5b5 into master Jan 20, 2024
4 checks passed
@NickEntin NickEntin deleted the entin/bazel branch January 20, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants