Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version code defaults to null, fix comment on manifest version #1475

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ data class ZiplineManifest private constructor(
/** Fully qualified main function to start the application (ie. "zipline.ziplineMain"). */
val mainFunction: String? = null,

/** Version to represent the code as defined in this manifest, by default it will be Git commit SHA. */
/** Version to represent the code as defined in this manifest */
val version: String? = null,

/**
Expand Down