Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Compile dependencies from node_modules #732

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

bnorm
Copy link
Contributor

@bnorm bnorm commented Sep 17, 2022

Resolves #725.

While this all seems to work, it still feels very much like a hack to me as I haven't explored a lot of edge cases. However, I wanted to open a draft PR early just to make sure this is the right approach or if there are other ideas. If you are comfortable with this approach I can start to clean things up and add some test cases.

I was able to get the trivia sample working with passing an Instant as a game parameter. However I switched to the world-clock sample for the PR since it was a more natural fit; it compiles but I haven't tested it for real yet.

@JakeWharton
Copy link
Collaborator

Seems like a great first step. Do you want feedback on the individual TODOs?

@bnorm
Copy link
Contributor Author

bnorm commented Sep 19, 2022

Seems like a great first step. Do you want feedback on the individual TODOs?

I would gladly take any feedback you have on TODOs! Quite a few are just notes to myself on what needs to be improved in the next round of changes so don't stress about it if you like the general direction this PR is going.

Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is really cool and something we certainly need. Please proceed !

@swankjesse
Copy link
Collaborator

After some research & experimentation, I think we’re gonna try to support a WASM-based future for this project. That means anything we build to better support NPM & JS ecosystem is gonna have a limited lifespan.

@Shabinder
Copy link
Contributor

Is this still active ?
Can see the mention of shift to WASM, and short lifespan on this if ever included until Zipline 2.0 arrives.

Couldn't resist asking, if yes, any eta on that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't crash compiling modules with NPM JS dependencies
4 participants