WIP: Compile dependencies from node_modules #732
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #725.
While this all seems to work, it still feels very much like a hack to me as I haven't explored a lot of edge cases. However, I wanted to open a draft PR early just to make sure this is the right approach or if there are other ideas. If you are comfortable with this approach I can start to clean things up and add some test cases.
I was able to get the trivia sample working with passing an
Instant
as a game parameter. However I switched to the world-clock sample for the PR since it was a more natural fit; it compiles but I haven't tested it for real yet.