Skip to content

Remove SATOCASH card support #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a1denvalu3 merged 2 commits into from
Feb 17, 2026
Merged

Remove SATOCASH card support #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa2914
Remove SATOCASH card support
a1denvalu3 Feb 16, 2026
12629b9
Remove SATOCASH files instead of commenting them out (fixes CI)
a1denvalu3 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions app/src/main/java/com/electricdreams/numo/ModernPOSActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import com.electricdreams.numo.feature.history.PaymentsHistoryActivity
import com.electricdreams.numo.payment.PaymentMethodHandler
import com.electricdreams.numo.ui.components.PosUiCoordinator

class ModernPOSActivity : AppCompatActivity(), SatocashWallet.OperationFeedback, AutoWithdrawProgressListener {
class ModernPOSActivity : AppCompatActivity(), AutoWithdrawProgressListener {

private var bitcoinPriceWorker: BitcoinPriceWorker? = null
private var vibrator: Vibrator? = null
Expand Down Expand Up @@ -215,18 +215,9 @@ class ModernPOSActivity : AppCompatActivity(), SatocashWallet.OperationFeedback,
else -> super.onOptionsItemSelected(item)
}

// SatocashWallet.OperationFeedback implementation
override fun onOperationSuccess() {
runOnUiThread {
// Feedback handled by PaymentResultHandler
}
}

override fun onOperationError() {
runOnUiThread {
// Feedback handled by PaymentResultHandler
}
}
// SatocashWallet.OperationFeedback implementation - DISABLED (2026-02-14)
// override fun onOperationSuccess() { }
// override fun onOperationError() { }

// AutoWithdrawProgressListener implementation
override fun onWithdrawStarted(mintUrl: String, amount: Long, lightningAddress: String) {
Expand Down
111 changes: 12 additions & 99 deletions app/src/main/java/com/electricdreams/numo/payment/NfcPaymentProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,116 +12,33 @@ import androidx.appcompat.app.AlertDialog
import androidx.appcompat.app.AppCompatActivity
import com.electricdreams.numo.R
import com.electricdreams.numo.ndef.NdefHostCardEmulationService
import com.electricdreams.numo.SatocashNfcClient
import com.electricdreams.numo.SatocashWallet

/**
* Handles NFC payment processing, including PIN dialogs and card communication.
* Handles NFC payment processing via HCE (Host Card Emulation).
*
* SATOCASH card support has been removed (2026-02-14).
*/
class NfcPaymentProcessor(
private val activity: AppCompatActivity,
private val onPaymentSuccess: (String) -> Unit,
private val onPaymentError: (String) -> Unit
) {

private var satocashClient: SatocashNfcClient? = null
private var satocashWallet: SatocashWallet? = null
private var savedPin: String? = null
private var waitingForRescan: Boolean = false
private var rescanDialog: AlertDialog? = null
private var processingDialog: AlertDialog? = null

/** Handle NFC tag for payment */
/** Handle NFC tag for payment - SATOCASH disabled */
@Deprecated("SATOCASH card support has been removed", ReplaceWith("Unit"))
fun handleNfcPayment(tag: Tag, requestedAmount: Long) {
if (requestedAmount <= 0) {
Toast.makeText(
activity,
activity.getString(R.string.nfc_payment_error_enter_amount_first),
Toast.LENGTH_SHORT
).show()
return
}

if (waitingForRescan && savedPin != null) {
// TODO: Re-implement full PIN-based rescan flow
Toast.makeText(
activity,
activity.getString(R.string.nfc_payment_error_rescan_not_supported),
Toast.LENGTH_SHORT
).show()
return
}

waitingForRescan = false

Thread {
try {
val tempClient = SatocashNfcClient(tag).also { it.connect() }
satocashClient = tempClient
satocashWallet = SatocashWallet(satocashClient)
satocashClient?.selectApplet(SatocashNfcClient.SATOCASH_AID)
satocashClient?.initSecureChannel()

try {
val token = satocashWallet!!.getPayment(requestedAmount, "SAT").join()
onPaymentSuccess(token)
return@Thread
} catch (e: RuntimeException) {
if (e.message?.contains("not enough funds") == true) {
onPaymentError(
activity.getString(R.string.nfc_payment_error_insufficient_funds)
)
return@Thread
}

val cause = e.cause
if (cause is SatocashNfcClient.SatocashException) {
val statusWord = cause.sw
if (statusWord == SW.UNAUTHORIZED) {
// TODO: Restore PIN entry + rescan UX
onPaymentError(
activity.getString(R.string.nfc_payment_error_pin_flow_not_implemented)
)
} else {
onPaymentError(
activity.getString(
R.string.nfc_payment_error_card_sw,
statusWord
)
)
}
} else {
onPaymentError(
activity.getString(
R.string.nfc_payment_error_generic,
e.message ?: ""
)
)
}
}
} catch (e: java.io.IOException) {
onPaymentError(
activity.getString(R.string.nfc_payment_error_nfc_comm, e.message ?: "")
)
} catch (e: SatocashNfcClient.SatocashException) {
onPaymentError(
activity.getString(
R.string.nfc_payment_error_satocash,
e.message ?: "",
e.sw
)
)
} catch (e: Exception) {
onPaymentError(
activity.getString(R.string.nfc_payment_error_unexpected, e.message ?: "")
)
} finally {
try {
satocashClient?.close()
satocashClient = null
} catch (_: java.io.IOException) {}
}
}.start()
// SATOCASH support has been removed
// This function is kept for API compatibility but does nothing
Toast.makeText(
activity,
"SATOCASH card support has been disabled",
Toast.LENGTH_SHORT
).show()
}

/** Show rescan dialog */
Expand Down Expand Up @@ -312,8 +229,4 @@ class NfcPaymentProcessor(
rescanDialog?.dismiss()
processingDialog?.dismiss()
}

private object SW {
const val UNAUTHORIZED = 0x9C06
}
}
Loading