-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NUT13-only Wallet with provided seed #127
Conversation
@davidcaseria Mind just rebaseing on main and squashing the commits? I can do it if not just let me know |
0260bb5
to
322ff90
Compare
fe28d17
to
b923481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR looks good. Think just remove the feature and good to go
I simplified your suggestion to a one-liner: |
Even better thanks |
The Wallet will now only support NUT -13-based secret derivation. The cdk user must provide a seed, which is used to generate an internal Xpriv.
Also, the database counter is changed to a u32 since the maximum value is
2^31-1
.Closes #111
Closes #125
Relies on #126