Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to work with 1.5.1 #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updates to work with 1.5.1 #65

wants to merge 1 commit into from

Conversation

sacherjj
Copy link

Added todo macro that needs updates, but compiles now.

@sacherjj sacherjj requested a review from goral09 June 15, 2023 21:47
@sacherjj sacherjj mentioned this pull request Jun 15, 2023
Closed
goral09
goral09 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@goral09 goral09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to never create a deploy with these keys for signing by users. If you do, the Ledger app will most probably crash/fail/error out since it doesn't know how to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goral09 goral09 goral09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sacherjj @goral09