Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full workflow in the docs #269

Merged
merged 27 commits into from
Mar 25, 2024
Merged

Add a full workflow in the docs #269

merged 27 commits into from
Mar 25, 2024

Conversation

ipopescu
Copy link
Contributor

@ipopescu ipopescu commented Mar 1, 2024

Corresponding documentation request: casper-network/docs#1299

New content:

  • An installation Quickstart (quickstart-guide.md)
  • A full installation guide with a brief review of the contract implementation (full-installation-tutorial.md)
  • A new file on querying the NFT contract (querying-NFTs.md)
  • A brief note on testing (testing-NFTs.md)

Modified content:

  • Moved the content from “using-casper-client.md” file to “interacting-with-NFTs.md”, and added a section for minting and transfers using the entrypoints. Kept the wasm calls the same. Added a “checking the balance” section. Added “Approving an Account” section. NOTE: the wasm client calls keep failing for me, and I need to investigate, but I haven't modified the commands. All the new content I added was tested and working.
  • I moved the “tutorials” folder under “docs”; this doesn’t seem to affect any of the docs.casper.network links.
  • Updated old links

A PR is also open in the docs repo to update the content there.

Copy link
Contributor

@ACStone-MTS ACStone-MTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@ipopescu ipopescu requested a review from gRoussac March 12, 2024 15:26
Copy link
Contributor

@gRoussac gRoussac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for your changes !

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ipopescu
Copy link
Contributor Author

Thank you for the reviews, @gRoussac and @ACStoneCL!

@ipopescu ipopescu merged commit 7815f09 into dev Mar 25, 2024
5 checks passed
@ipopescu ipopescu deleted the 1299_full_tutorial branch March 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants