Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating casper-node dependency to use new Transaction definition; up… #345

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

zajko
Copy link
Contributor

@zajko zajko commented Oct 23, 2024

…dating tests

@zajko zajko force-pushed the aligning_to_rc5 branch 3 times, most recently from d18eeb9 to e568bed Compare October 24, 2024 10:43
Copy link

@fizyk20 fizyk20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but I don't see any that would be related to casper-node or the Transaction definition, and the description seems to indicate that there should be some... Are some commits missing, maybe, or is it just me who is missing something?

@zajko
Copy link
Contributor Author

zajko commented Oct 24, 2024

The changes look good to me, but I don't see any that would be related to casper-node or the Transaction definition, and the description seems to indicate that there should be some... Are some commits missing, maybe, or is it just me who is missing something?

So Sidecar doesn't really mess a lot with the internals of the transaction - it pushes it to DB as a whole on the SSE part and pushes it from json RPC to binary port as a whole in the RPC part. So actually sidecar mostly is dependant on the type definition that comes from casper-types and updating it was a big part of the work :)
but you can see that we have some tests that depend on comparing json representations and that did need changing since the json representation of a transaction changed

@zajko zajko merged commit fca0147 into casper-network:feat-2.0 Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants