Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging and set exit code according to the exit status #210

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Improve logging and set exit code according to the exit status #210

merged 1 commit into from
Jan 3, 2025

Conversation

kasia-kujawa
Copy link
Contributor

@kasia-kujawa kasia-kujawa commented Jan 2, 2025 •
edited
Loading

for details please see comments in the code

example logs without changes from this pull request when provider env was set to wrong value:

time="2025-01-02T15:06:02Z" level=info msg="closing healthz server" component_node_name=ip-192-168-48-224.eu-central-1.compute.internal component_pod_name=castai-agent-749d64cb88-6d2tr version=v0.76.0
time="2025-01-02T15:06:02Z" level=warning msg="healthz server closed" component_node_name=ip-192-168-48-224.eu-central-1.compute.internal component_pod_name=castai-agent-749d64cb88-6d2tr version=v0.76.0
time="2025-01-02T15:06:02Z" level=info msg="closing pprof server" component_node_name=ip-192-168-48-224.eu-central-1.compute.internal component_pod_name=castai-agent-749d64cb88-6d2tr version=v0.76.0
time="2025-01-02T15:06:02Z" level=warning msg="pprof server closed" component_node_name=ip-192-168-48-224.eu-central-1.compute.internal component_pod_name=castai-agent-749d64cb88-6d2tr version=v0.76.0
time="2025-01-02T15:06:02Z" level=info msg="context done" component_node_name=ip-192-168-48-224.eu-central-1.compute.internal component_pod_name=castai-agent-749d64cb88-6d2tr version=v0.76.0
time="2025-01-02T15:06:17Z" level=error msg="failed to send logs after shutdown timed out"

example logs with changes from this pull request when provider env was set to wrong value:

time="2025-01-02T15:09:02Z" level=info msg="closing healthz server" component_node_name=ip-192-168-9-86.eu-central-1.compute.internal component_pod_name=castai-agent-67798b9989-dq7rc version=local
time="2025-01-02T15:09:02Z" level=warning msg="healthz server closed" component_node_name=ip-192-168-9-86.eu-central-1.compute.internal component_pod_name=castai-agent-67798b9989-dq7rc version=local
time="2025-01-02T15:09:02Z" level=info msg="closing pprof server" component_node_name=ip-192-168-9-86.eu-central-1.compute.internal component_pod_name=castai-agent-67798b9989-dq7rc version=local
time="2025-01-02T15:09:02Z" level=warning msg="pprof server closed" component_node_name=ip-192-168-9-86.eu-central-1.compute.internal component_pod_name=castai-agent-67798b9989-dq7rc version=local
time="2025-01-02T15:09:02Z" level=error msg="getting provider: unknown provider \"test\""
time="2025-01-02T15:09:02Z" level=info msg="context done" component_node_name=ip-192-168-9-86.eu-central-1.compute.internal component_pod_name=castai-agent-67798b9989-dq7rc version=local
time="2025-01-02T15:09:17Z" level=error msg="failed to send logs after shutdown timed out"

@kasia-kujawa kasia-kujawa marked this pull request as ready for review January 2, 2025 16:13
@kasia-kujawa kasia-kujawa merged commit 185812d into main Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pijusn-cast pijusn-cast pijusn-cast approved these changes

@saumas saumas Awaiting requested review from saumas saumas is a code owner

@mindaugasCast mindaugasCast Awaiting requested review from mindaugasCast mindaugasCast is a code owner

@dariuspie dariuspie Awaiting requested review from dariuspie dariuspie is a code owner

@zilvinasu zilvinasu Awaiting requested review from zilvinasu zilvinasu is a code owner

@KarolisL KarolisL Awaiting requested review from KarolisL KarolisL is a code owner

@mikenorgate mikenorgate Awaiting requested review from mikenorgate mikenorgate is a code owner

@jakubsolecki jakubsolecki Awaiting requested review from jakubsolecki jakubsolecki is a code owner

@vladklokun vladklokun Awaiting requested review from vladklokun vladklokun is a code owner

@linkas45 linkas45 Awaiting requested review from linkas45 linkas45 is a code owner

@laimonasr laimonasr Awaiting requested review from laimonasr laimonasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasia-kujawa @pijusn-cast