Skip to content

Unjank HNSW searching #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2023
Merged

Unjank HNSW searching #2268

merged 2 commits into from
Nov 22, 2023

Conversation

lintool
Copy link
Member

@lintool lintool commented Nov 21, 2023

Ref #2267

@lintool lintool marked this pull request as draft November 21, 2023 13:19
@lintool lintool requested a review from MXueguang November 21, 2023 13:20
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (9d34274) 62.88% compared to head (823a26a) 62.95%.

Files Patch % Lines
...ava/io/anserini/search/SearchHnswDenseVectors.java 69.86% 18 Missing and 4 partials ⚠️
...io/anserini/search/SearchInvertedDenseVectors.java 83.33% 6 Missing and 2 partials ⚠️
...main/java/io/anserini/search/SearchCollection.java 87.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2268      +/-   ##
============================================
+ Coverage     62.88%   62.95%   +0.06%     
- Complexity     1257     1271      +14     
============================================
  Files           196      196              
  Lines         11510    11418      -92     
  Branches       1478     1452      -26     
============================================
- Hits           7238     7188      -50     
+ Misses         3729     3708      -21     
+ Partials        543      522      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool marked this pull request as ready for review November 21, 2023 22:34
@lintool
Copy link
Member Author

lintool commented Nov 21, 2023

This is ready for review!

MXueguang
MXueguang approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@MXueguang MXueguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ArthurChen189
ArthurChen189 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ArthurChen189 ArthurChen189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lintool lintool merged commit ae498aa into master Nov 22, 2023
@lintool lintool deleted the hnsw-refactoring branch November 22, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MXueguang MXueguang MXueguang approved these changes

@ArthurChen189 ArthurChen189 ArthurChen189 approved these changes

@tteofili tteofili Awaiting requested review from tteofili

@cadurosar cadurosar Awaiting requested review from cadurosar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lintool @MXueguang @ArthurChen189