Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LTR code #2678

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove LTR code #2678

merged 2 commits into from
Jan 17, 2025

Conversation

lintool
Copy link
Member

@lintool lintool commented Jan 12, 2025

Completely ripping out LTR stuff, because the technology is defunct, and we're just dragging along dead code. Thoughts?

@lintool lintool marked this pull request as draft January 12, 2025 22:58
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.10%. Comparing base (d847b4b) to head (a61b13e).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2678      +/-   ##
============================================
+ Coverage     66.02%   67.10%   +1.07%     
+ Complexity     1488     1191     -297     
============================================
  Files           225      182      -43     
  Lines         13023    11344    -1679     
  Branches       1553     1369     -184     
============================================
- Hits           8598     7612     -986     
+ Misses         3894     3229     -665     
+ Partials        531      503      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool marked this pull request as ready for review January 16, 2025 20:23
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, not sure who uses these features in Anserini.

@lintool lintool merged commit 7c1de0e into master Jan 17, 2025
3 checks passed
@lintool lintool deleted the noltr branch January 17, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants