-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HNSW support to the localhost API interface #2691
Merged
+1,279
−313
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
235a9c7
hnsw endpoint added
vincent-4 f77f1bc
use primitive
vincent-4 1ed836e
checks
vincent-4 37597ff
don't require parms
vincent-4 7e0e1db
Add settings toggle, remove doc return attempt for HNSW, add paramete…
vincent-4 4cbf066
use indexInfo settings
vincent-4 75ba6e0
indexinfo
vincent-4 529eb43
search: Improve HNSW search implementation and IndexInfo organization
vincent-4 7279255
fix and simplify: Improve resource handling and type safety
vincent-4 b545008
refactors: Improve code organization and error handling
vincent-4 c71251f
re-order: Improve code readability and organization
vincent-4 b8de5d6
Remove searching without index and improve error handling
vincent-4 6bfb91b
un-remove the 3 removed indexinfo entries -- accident
vincent-4 9e28c66
API Version Bump, style, and cleanup
vincent-4 10413ac
refactor(api): improve error handling and service management
vincent-4 273eb06
refactor(api): improve encoder/generator class handling and remove no…
vincent-4 3922dbe
Undo change to testNumPrebuiltIndexes - 169 as it was before
vincent-4 f0aaf5a
refactor(server): rename ControllerV1_0 to Controller and add SearchS…
vincent-4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we add a new field in the
Enum
inIndexInfo
so we don't have to do this janky check?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indexes need to be paired with generators and encoders, right? so put that in
IndexInfo
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each enum? Or something different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, why not? Add another field in the enum denoting indexing type, the encoder, and the query generator?