perf: --depth=1 shallow clone for end users
#203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rather than cloning the entire history of repos, can do a shallow clone with a [depth](https://git-scm.com/docs/git-clone#Documentation/git-clone.txt-code--depthcodeemltdepthgtem) of 1 - this should make it more efficient, particularly when there are many commits or many large commits - since the history is unused by regular end users, there is no need to fetch/download it - could alternatively do a [bare](https://git-scm.com/docs/git-clone#Documentation/git-clone.txt-code--barecode) clone to be even more efficient - but I thought a shallow clone is a bit less intrusive for now - and is reversible, if needed (i.e. a local shallow clone can fetch the rest of the depth) - also add syntax highlighting to the first code block, matching the second one
|
Thanks! I have merged this to my forked repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Speed up downloads of the script with a more efficient shallow clone
Details
rather than cloning the entire history of the repo, can do a shallow clone with a depth of 1
also add syntax highlighting to the first code block, matching the second one
Notes to Reviewers
References
This is largely equivalent to ryanrudolfoba/SteamOS-Waydroid-Installer#198