Skip to content

Fix capitalizations in bibtex files #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

Fix capitalizations in bibtex files #4209

merged 3 commits into from
May 16, 2025

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Apr 23, 2025

Overview

What problem does this address?

BibTeX tries to "help" by applying consistent case to titles depending on the bibliography format being generated. Unfortunately it doesn't know about proper nouns, but fortunately it lets a human say "no really you should leave this capitalized".

What did you change?

Added {} around:

  • proper nouns
  • initialisms
  • abbreviations

in all titles (only)

Switched to un-braced month abbreviations for all months, which BibTeX claims is the preferred format that styles will do the right thing with.

Documentation

Make sure to update relevant aspects of the documentation:

  • Update the release notes: reference the PR and related issues.
  • Update relevant Data Source jinja templates (see docs/data_sources/templates).
  • Update relevant table or source description metadata (see src/metadata).
  • Review and update any other aspects of the documentation that might be affected by this PR.

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

  • If updating analyses or data processing functions: make sure to update row count expectations in dbt tests.
  • Run make pytest-coverage locally to ensure that the merge queue will accept your PR.
  • Review the PR yourself and call out any questions or issues you have.
  • For minor ETL changes or data additions, once make pytest-coverage passes, make sure you have a fresh full PUDL DB downloaded locally, materialize new/changed assets and all their downstream assets and run relevant data validation tests using pytest and --live-dbs.
  • For bigger ETL or data changes run the full ETL locally and then run the data validations using make pytest-validate.
  • Alternatively, run the build-deploy-pudl GitHub Action manually.

@krivard krivard added the docs Documentation for users and contributors. label Apr 23, 2025
@@ -86,7 +86,7 @@ @inproceedings{ModelNotDataWork
}

@book{stokes2020short,
title = {Short Circuiting Policy: Interest Groups and the Battle Over Clean Energy and Climate Policy in the American States},
title = {Short Circuiting Policy: Interest Groups and the Battle Over Clean Energy and Climate Policy in the {American States}},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure about "states" here so i went with the geography version

@zaneselvans zaneselvans moved this from New to In progress in Catalyst Megaproject May 16, 2025
@zaneselvans
Copy link
Member

@krivard Any reason not to go ahead and merge this guy?

@krivard krivard marked this pull request as ready for review May 16, 2025 12:55
@krivard krivard requested a review from zaneselvans May 16, 2025 12:55
@krivard krivard added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 9c75267 May 16, 2025
17 checks passed
@krivard krivard deleted the fix-bib-typos branch May 16, 2025 16:42
@github-project-automation github-project-automation bot moved this from In progress to Done in Catalyst Megaproject May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation for users and contributors.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants