Issue #8: Added Checks API hook for checking hashes by Peterburnett · Pull Request #9 · catalyst/moodle-tool_hashlegacy

Peterburnett · 2020-03-17T06:31:57Z

Closes Issue #8 .
Only concern is whether these are the correct thresholds

brendanheywood · 2020-03-17T06:37:53Z

lib.php

 }
+
+function tool_hashlegacy_security_checks() {
+    if (class_exists('\core\check\check') && class_exists('\core\check\result')) {


do you need this? If the core lib doesn't exist this should never get called

brendanheywood · 2020-03-17T06:39:03Z

classes/check/hashlegacy.php

+
+class hashlegacy extends check {
+
+    const WARNING_THRESHOLD = 0.2;


I'd probably make this much simpler and say any old hash is a warning, even a single one. We just want them removed

Added Checks API hook for checking hashes

9e19ff5

brendanheywood reviewed Mar 17, 2020

View reviewed changes

Provide feedback


		class hashlegacy extends check {

		const WARNING_THRESHOLD = 0.2;