Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DLC #1047

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Refactor DLC #1047

merged 3 commits into from
Sep 2, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Aug 30, 2024

@CodyCBakerPhD
The core of the refactor is breaking appart the following function

Which is doing too many things:

  • locates metadata
  • Parses skeleton if exists
  • locates and parses config.yaml
  • Extracts the video file path
  • Parses timestamps from the video

Into more mangeable and specific functions: get_graf_edges, get_video_info_from_config_file.

Related to this:

#1046

And also related to the Cohen conversion where we don't have the config.yaml available. In that case, I will need this refactor to expose passing the video_file_path instead of extracting it from the config.yaml.

This is needed before #1031.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) September 2, 2024 06:11
@CodyCBakerPhD CodyCBakerPhD merged commit 77d2252 into main Sep 2, 2024
33 of 35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the refactor_deeplab_cut branch September 2, 2024 09:27
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (905dc73) to head (f865444).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...v/datainterfaces/behavior/deeplabcut/_dlc_utils.py 89.47% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.01%     
==========================================
  Files         129      129              
  Lines        7924     7931       +7     
==========================================
+ Hits         7165     7171       +6     
- Misses        759      760       +1     
Flag Coverage Δ
unittests 90.41% <89.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...v/datainterfaces/behavior/deeplabcut/_dlc_utils.py 58.38% <89.47%> (+1.89%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants