Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve temporally_align_data_interfaces #1162

Merged
merged 6 commits into from
Jan 20, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated tests
  • Loading branch information
pauladkisson committed Dec 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a9b6962f93c1ecc82cbe0a1390d5917b3cffd7eb
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
from pathlib import Path
from shutil import rmtree
from tempfile import mkdtemp
from typing import Dict, Union
from typing import Dict, Optional, Union

import numpy as np
from hdmf.testing import TestCase
@@ -186,7 +186,9 @@ class TestAlignmentConverter(NWBConverter):
NIDQ=MockSpikeGLXNIDQInterface, Trials=CsvTimeIntervalsInterface, Behavior=MockBehaviorEventInterface
)

def temporally_align_data_interfaces(self):
def temporally_align_data_interfaces(
self, metadata: Optional[dict] = None, conversion_options: Optional[dict] = None
):
unaligned_trial_start_times = self.data_interface_objects["Trials"].get_original_timestamps(
column="start_time"
)
Loading