check for stale cluster info before retrying #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we keep stale data from the cluster even when we try to reread the leader.
|
could we try this approach instead https://github.com/zendesk/ruby-kafka/pull/901/files (back port from main repo) and see if this will solve an issue. (Just to be closer to the main repo) |
|
I think we will need both, but yeah, good call |
sarcilav
changed the title
|
@dhruvCW the issue is more evident if you spawn more than one consumer process, as you start dealing with more changes in the state of the cluster, which will create more chances for the cluster data in the clients to go stale, and basically this change tries to refresh the cluster metadata before retrying after an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we keep stale data from the cluster even when we try to reread the leader.
so basically
#get_leaderkeeps getting the same error over on NotLeaderForPartition, when leader rebalance happens and we are sending a batch, and it wasn't triggering a reread.