Node runtime and package updates

[jjosef]

Fixes #55

[rwxdash]

Hey @jjosef, thank you for opening the PR.

Can you run npm run format and commit the linting changes? Since prettier is upgraded with this PR, I assume some of the default conf have changed and causing the build to fail.

Thanks.

[jjosef]

Hey @jjosef, thank you for opening the PR.

Can you run npm run format and commit the linting changes? Since prettier is upgraded with this PR, I assume some of the default conf have changed and causing the build to fail.

Thanks.

Done!

[jjosef]

Also upgraded ncc and typescript packages. seems to build fine now

[rwxdash]

Thank you @jjosef. Looks good to me and the updates are probably OK, but just to be sure, have you had any chance to test the action from your fork to see things are working? If not, I'll try to make some time to test it out and approve/merge from there.

cc\ @serkan-ozal

[rwxdash]

Additionally, the release for this PR should be a major as it changes the runtime from node16 to node20.

cc\ @serkan-ozal

[jjosef]

Thank you @jjosef. Looks good to me and the updates are probably OK, but just to be sure, have you had any chance to test the action from your fork to see things are working? If not, I'll try to make some time to test it out and approve/merge from there.

cc\ @serkan-ozal

Yes I am using it in production for my company currently

[rwxdash]

Looks good to me. Thank you, @jjosef!

[fwilhe]

Merging this PR into main would be appreciated.

We are using a fork of this action but i don't want unnecessary large diverges from upstream, so I'd like to use the commit(s) from the main branch.

Thank you

[rwxdash]

Merging it, as it looks OK at this stage and no further review required.

Thank you.

[johanneswuerbach]

@rwxdash any chance to get this released? Maybe as v2?

[serkan-ozal]

Hi @johanneswuerbach,

Sorry for late reply. Yes, we should definitely release it. But I think, we can still release it as v1.
@rwxdash WDYT?

[johanneswuerbach]

Most actions I've seen released the node upgrade as major (e.g. actions/checkout or docker/build-push-action). I guess this is mainly due to the fact that actions can also be used on self-hosted runners / self-hosted github and there the new node version might not be available yet.

[rwxdash]

Hey @johanneswuerbach @serkan-ozal,

Yes, my initial thought was to release it as v2 as well since it's the convention I see from other actions. If v2 sounds good @serkan-ozal, I can prepare the action for it and we can do the release.

[serkan-ozal]

Hmm, OK makes sense. @rwxdash could you please release as v2

[rwxdash]

v2 has been released. Thank you all for pushing this through!