Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - prevent page reload on token refresh #25

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oyo
Copy link
Contributor

@oyo oyo commented Oct 28, 2022

With revokeRefreshToken: true frontend apps are unable to run in different browser tabs or windows sharing the same user access token. On the portal frontend this will trigger a page reload on token refresh.

https://jira.catena-x.net/browse/CPLP-1677

@oyo oyo requested review from ntruchsess, evegufy and jjeroch October 28, 2022 07:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@evegufy
Copy link
Contributor

evegufy commented Oct 28, 2022

@oyo as discussed, please set the PR to draft (I think I don't have the permissions to do that for someone elses PR) as we're currently not sure if that's the way to go.

@oyo oyo marked this pull request as draft November 2, 2022 14:43
@evegufy
Copy link
Contributor

evegufy commented Feb 12, 2024

Issue discussed in workshop https://github.com/eclipse-tractusx/portal-iam/blob/main/docs/consultation/workshop-20231005.md#user-token-lifespan, so change in config planned. I suggest to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants