Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing colors in classes, outdated IDs, add item list theming #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

popcar2
Copy link

@popcar2 popcar2 commented Feb 21, 2025

Before After
image image

This PR updates all four Catppuccin themes to work with the newest version of Joplin.

Specifically:

  • Added the missing cm-editor background color. The markdown editor before was using the default Joplin theme's background.
  • Added missing classes for theming the note item panels on the left. Highlighted and selected colors previously used the default Joplin theme colors.

It's possible there's some old CSS that does nothing now because I assume this was themed in the past, but class names changed over time. Who cares though, what matters is that it looks good now and I can finally stop debugging front-ends.

…ors (#2)

Fixes the coloring scheme of the two panels on the left. Some IDs were outdated, some classes were missing.
@popcar2 popcar2 changed the title Fix missing cm-editor background colors Fix missing colors in classes, outdated IDs, add item list theming Feb 22, 2025
@ghostx31
Copy link
Member

Thanks for the PR!
I'll check this out in the evening and if everything's fine, I'll merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants