Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react.dev): init #1588

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

RaiderHCPlay
Copy link

🎉 Theme for React 🎉

mocha
macchiato
latte
frappe

React is a popular JavaScript library used for building user interfaces, particularly for web and mobile applications.

💬 Additional Comments 💬

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the userstyles.yml file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.less - all the CSS for the userstyle, based on the template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@uncenter
Copy link
Member

uncenter commented Jan 22, 2025

None of the generated files should be present. That is all done automatically. Please remove the changes from those scripts.

(I've noticed the potential for confusion here though, working on some clarifications to the scripts to make this clearer to new contributors)

@RaiderHCPlay
Copy link
Author

I removed the autogenerated files. I hope everything is fine now.

Co-authored-by: RaiderHCPlay <fabryckipawel@gmail.com>
@uncenter
Copy link
Member

You still had lots of changes that can't be made. I squashed all your commits on this branch into one and removed the unwanted changes. In the future, only run commands that the contributing instructions tell you to run. Avoid including/modifying other files, like the styles/react/catppuccin.user.css file - that was not needed, and not mentioned in the documentation as something that needed to be added either (it is a "stub" file for a mass file rename we did earlier in January: #1546).

@RaiderHCPlay
Copy link
Author

I though css file was needed. Sorry about that and thank you.

scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
styles/react/catppuccin.user.less Outdated Show resolved Hide resolved
styles/react/catppuccin.user.less Outdated Show resolved Hide resolved
styles/react/catppuccin.user.less Outdated Show resolved Hide resolved
styles/react/catppuccin.user.less Outdated Show resolved Hide resolved
styles/react/preview.webp Outdated Show resolved Hide resolved
@uncenter uncenter changed the title feat(react): init feat(react.dev): init Jan 23, 2025
@uncenter
Copy link
Member

Please please pull the branch before pushing new changes. You just merged your old branch into the updated branch and now undid all the squashing I had done.

@uncenter uncenter marked this pull request as draft January 23, 2025 12:55
@RaiderHCPlay RaiderHCPlay marked this pull request as ready for review January 23, 2025 13:34
@RaiderHCPlay RaiderHCPlay requested a review from uncenter January 23, 2025 14:06
@uncenter
Copy link
Member

In the future you can ideally use these buttons to add suggestions, which makes it clearer to understand which suggestions/comments have been resolved.

image

@RaiderHCPlay
Copy link
Author

I applied all your requested changes, I fixed every detail I could saw and I updated looking of these color fragments of website:
image

@RaiderHCPlay RaiderHCPlay requested a review from uncenter January 28, 2025 11:49
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color of the line under code block tabs:

image

Text of social links on https://react.dev/community/team:
CleanShot 2025-01-31 at 21 14 15

Down arrow of "deep dive" callouts on https://react.dev/reference/react/useCallback:

CleanShot 2025-01-31 at 21 14 47
CleanShot 2025-01-31 at 21 14 53

Search bar on focus:

CleanShot 2025-01-31 at 21 15 59

Cancel button in top right while typing in search bar:

CleanShot 2025-01-31 at 21 16 37

styles/react.dev/catppuccin.user.less Outdated Show resolved Hide resolved
styles/react.dev/catppuccin.user.less Outdated Show resolved Hide resolved
styles/react.dev/catppuccin.user.less Outdated Show resolved Hide resolved
@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Feb 1, 2025
@RaiderHCPlay
Copy link
Author

RaiderHCPlay commented Feb 1, 2025

I applied all requested changes

@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Feb 2, 2025
@uncenter
Copy link
Member

uncenter commented Feb 2, 2025

Last things and then this is good to merge!

Border in these expanded deep dive callouts (again see https://react.dev/reference/react/useCallback):

CleanShot 2025-02-02 at 12 49 51

Below the above pictured deep dives is this tabbed component - the forward/back buttons look unthemed, and the not-current tab border bottom is also unthemed.

CleanShot 2025-02-02 at 12 50 30

@RaiderHCPlay
Copy link
Author

Changes applied.

@RaiderHCPlay RaiderHCPlay requested a review from uncenter February 4, 2025 07:29
@uncenter
Copy link
Member

Two final things!

Links on hover have this underline unthemed in the footer of the root page:

CleanShot 2025-02-12 at 07 32 18

The "Console" text is unthemed (again in one of the code samples on https://react.dev/reference/react/useCallback):
CleanShot 2025-02-12 at 07 31 12

Co-authored-by: mxgic1337_ <60188749+mxgic1337@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants