refactor(google): add a lot of styles to ogs, use and add gm3 tokens for modern component styling#1680
Closed
WalkQuackBack wants to merge 3 commits intocatppuccin:mainfrom
Closed
Conversation
…for modern component styling
Member
Author
|
Waiting on decision of how organization handles Google userstyles. |
uncenter
added
the
2.status: pending
Member
Author
|
Closing in favour of a shared library approach later down the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 What does this fix? 🔧
As of now, the ogs Google dialogue is not themed very consistently and a lot of elements are unthemed.
Before:
Colour on focused border and elevated card background
Accent colour, state layer on hairline/outlined button, accent colour, state layer, background on tonal button, accent colour on icons, background and text on badges, text on dismiss icon
After:
This refactor attempts to make styling more consistent by directly using and modifying the CSS bundles that are provided by Google, decreasing the chance that styles are missed and making the look more consistent.
🗒 Checklist 🗒