Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor credit-related code and be ready for coin accepter/bill accepter hardware #58

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Refactor credit-related code and be ready for coin accepter/bill accepter hardware #58

merged 8 commits into from
Jun 10, 2024

Conversation

LiteHell
Copy link
Member

@LiteHell LiteHell commented Jun 7, 2024

  • Display "FREE PLAY" if price is zero
  • Price can be set with --price parameter when running (Default is 2 credits)
  • Game can be built as uncommericial version when uncommercial feature is set
    • It's required for rating exemption, by guideline of GRAC
  • Bill acceptor/Coin acceptor can be used
    • The controller should set 5th bit when bill/coins are accepted.
    • Credits will be increased at rising edge of 5th bit

@LiteHell LiteHell self-assigned this Jun 7, 2024
@LiteHell LiteHell requested review from boulce and firekann June 7, 2024 00:38
boulce
boulce approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@boulce boulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

firekann
firekann approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@firekann firekann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiteHell LiteHell merged commit 737a0d8 into main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulce boulce boulce approved these changes

@firekann firekann firekann approved these changes

Assignees

@LiteHell LiteHell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiteHell @firekann @boulce