Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SorrTask1032_Unit_test_Master_system_run_debugger #1048

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

heanhsok
Copy link
Collaborator

Task #1032

Add Unit test for oms/notebooks/Master_system_run_debugger.ipynb to Test_run_master_notebooks located at oms/test/test_notebooks.py

  • Create a config builder function at oms/execution_analysis_configs.py
  • Create a corresponding test method at Test_run_master_notebooks

@heanhsok heanhsok self-assigned this Jun 14, 2024
@heanhsok heanhsok changed the title Add Unit test for Master_system_run_debugger SorrTask1032_Unit_test_Master_system_run_debugger Jun 14, 2024
@heanhsok heanhsok marked this pull request as ready for review June 14, 2024 14:33
@heanhsok heanhsok added the PR_for_reviewers The PR needs to be reviewed by Team Leaders label Jun 14, 2024
Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, see 1 nit, I'll finish it a bit later

@DanilYachmenev DanilYachmenev added PR_for_authors The PR needs changes and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels Jun 14, 2024
@heanhsok heanhsok added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_authors The PR needs changes labels Jun 14, 2024
@heanhsok heanhsok requested a review from DanilYachmenev June 14, 2024 15:24
Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, gj
I'll run on my side and debug if needed

Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@DanilYachmenev DanilYachmenev added Paused An issue was started and then stopped and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels Jun 18, 2024
@DanilYachmenev
Copy link
Collaborator

Needs some refactoring and data transferring for unit tests from shared to s3
will do slightly later
overall PR is good

Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some cleanup comments and done
I will take care of unit test data later on

@DanilYachmenev DanilYachmenev added the PR_for_authors The PR needs changes label Jun 20, 2024
@heanhsok
Copy link
Collaborator Author

there seems to be error in the dependencies installation step when the fast test is run.

https://github.com/kaizen-ai/kaizenflow/actions/runs/9606304520/job/26495614380?pr=1048

Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: pip in /usr/lib/python3/dist-packages (22.0.2)
Collecting pip
  Downloading pip-24.1-py3-none-any.whl (1.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.8/1.8 MB 47.7 MB/s eta 0:00:00
Installing collected packages: pip
Successfully installed pip-24.1
Defaulting to user installation because normal site-packages is not writeable
ERROR: Invalid requirement: 'pytest >= "6.0.0"': Expected end or semicolon (after name and no valid version specifier)
    pytest >= "6.0.0"
           ^ (from line [15](https://github.com/kaizen-ai/kaizenflow/actions/runs/9606371313/job/26495796074#step:7:16) of .github/gh_requirements.txt)
Error: Process completed with exit code 1.

@heanhsok heanhsok removed the PR_for_authors The PR needs changes label Jun 21, 2024
@heanhsok heanhsok added the PR_for_reviewers The PR needs to be reviewed by Team Leaders label Jun 21, 2024
@heanhsok heanhsok requested a review from DanilYachmenev June 21, 2024 00:51
@DanilYachmenev
Copy link
Collaborator

there seems to be error in the dependencies installation step when the fast test is run.

It's fine, there is no data in the corresponding unit test bucket for this test on s3
And you have no access to it yet either

code skeleton is ready, we will proceed on it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paused An issue was started and then stopped PR_for_reviewers The PR needs to be reviewed by Team Leaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants