Dynamic retry policies #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When asking the retry policy to decide the next step, pass the result of the last attempt. Depending on the combinator, this could be a value or an error. This allows users to implement more exotic retry policies, e.g. choosing to retry some kinds of error quickly, but using exponential backoff for others. All the built-in policies maintain their existing behaviour: they ignore the action result and decide the next step based on static rules. This was quite a noisy change because it involved adding a new type parameter to `RetryPolicy`.
"Dynamic" in the sense that it chooses a retry policy based on the result of the last attempt. Depending on the combinator, that might be a value or an error.
cb372
force-pushed
the
dynamic-retry-policies
branch
from
69f8100 to
deb663c
Compare
AlejandroBudy
approved these changes
Jan 9, 2025
cb372
added a commit
that referenced
this pull request
Jan 10, 2025
I forgot to update them as part of #550
cb372
added a commit
that referenced
this pull request
Jan 10, 2025
I forgot to update them as part of #550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #506.
When asking the retry policy to decide the next step, pass the result of the last attempt. Depending on the combinator, this could be a value or an error.
Before:
After:
This allows users to implement more exotic retry policies, e.g. choosing to retry some kinds of error quickly, but using exponential backoff for others. I've added
RetryPolicies.dynamicto support that.All the built-in policies maintain their existing behaviour: they ignore the action result and decide the next step based on static rules.
This was quite a noisy change because it involved adding a new type parameter to
RetryPolicy.