Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adding data validation for demand drafts (notebook + code) #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heaven00
Copy link
Member

No description provided.

Copy link
Member

@gggodhwani gggodhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the following comments

@@ -0,0 +1,99 @@
import re
import json
from goodtables import validate, check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to requirements.txt

def missing_budget_code(errors, cells, row_number):
'''
Check for missing budget codes where particulars are present.
'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add doc for args and return variables

@check('numbers-only', type='custom', context='body')
def numbers_only(errors, cells, row_number):
'''
Check if there are numbers only in the Numeric Columns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add doc for args and return variables

@heaven00
Copy link
Member Author

Let's add them when we can later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants