Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CSV delimiter to a comma #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nithishbn
Copy link

Having a semicolon as the delimiter feels a little unorthodox for a CSV. Having it be a comma makes it easier to load into various applications without an explicit delimiter.

@cbouy
Copy link
Owner

cbouy commented Nov 13, 2024

Hi and thanks for the contribution!

It's unorthodox indeed, but in a lot of European countries the comma is often used for decimal points so a semicolon ends up being used as delimiter for CSVs in a lot of applications.
Ideally we would change the delimiter based on the locale being used, something like:

import locale
decimal_point = locale.localeconv()['decimal_point']
delimiter = ';' if decimal_point == ',' else ","

and use that instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants