Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seperat link command for Winsock #333

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+6 −1
Open

seperat link command for Winsock #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
179374f
seperat link command for Winsock
Davknapp Dec 17, 2024
655b390
Add BSD-statement
Davknapp Dec 17, 2024
28198c5
Apply suggestion
Davknapp Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ target_include_directories(p4est PUBLIC
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src>
$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include>
$<INSTALL_INTERFACE:include>)
target_link_libraries(p4est PUBLIC SC::SC $<$<BOOL:${P4EST_HAVE_WINSOCK2_H}>:${WINSOCK_LIBRARIES}>)
target_link_libraries(p4est PUBLIC SC::SC )

if ( WIN32)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, happy to merge! Is this supposed to be a space (in this case please remove) or an underscore?

target_linke_libaries(p4est PUBLIC ${WINSOCK_LIBRARIES})
endif()

# imported target, for use from parent projects
add_library(P4EST::P4EST INTERFACE IMPORTED GLOBAL)
Expand Down
1 change: 1 addition & 0 deletions doc/author_knapp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
I place my contributions to p4est under the FreeBSD license. David Knapp (david.knapp@dlr.de)
Loading