Skip to content

Conversation

@wagnerlmichael
Copy link
Member

@wagnerlmichael wagnerlmichael commented Feb 3, 2026

We need to update the way the pipeline interacts with sales val columns because we recently made significant data model changes that incorporate manual analyst review. Res equivalent.

@wagnerlmichael wagnerlmichael marked this pull request as ready for review February 3, 2026 21:57
@jeancochrane
Copy link
Member

I reran the ingest and updated the DVC lockfile in f107c88, then kicked off model run 2026-02-03-pensive-iris. The reports are broken for that model run, which is what we expect, but I did a quick check to confirm that predictions are populated as expected:

select meta_pin, meta_card_num, pred_card_initial_fmv
from model.assessment_card
where run_id = '2026-02-03-pensive-iris' and meta_class = '299'
limit 1000

I also checked the training data locally in RStudio to confirm that we see review flags:

training <- read_parquet("input/training_data.parquet")
training %>% count(sv_is_outlier)
training %>% count(sv_outlier_reason) %>% arrange(desc(n))

Comment on lines +517 to +518
- path:
output/performance_quantile/model_performance_quantile_assessment.parquet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as ccao-data/model-res-avm#433, I'm not sure why my version of DVC wants to break these onto multiple lines, but I figure it doesn't matter too much.

@jeancochrane
Copy link
Member

Alright @wrridgeway, this looks good to me, so I'm sending it over to you since I contributed to it.

Copy link
Member

@wrridgeway wrridgeway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys, this is great. Appreciate the single outlier column that contains so much info.

@jeancochrane jeancochrane merged commit c2774e4 into master Feb 4, 2026
5 checks passed
@jeancochrane jeancochrane deleted the Update-pipeline-with-outlier-column-changes branch February 4, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants