Update outlier section of performance report for sales val changes #131
Conversation
wagnerlmichael
changed the title
| "Algorithm: Outlier, High price", | ||
| str_detect(sv_outlier_reason, "Low price") ~ | ||
| "Algorithm: Outlier, Low price", | ||
| TRUE ~ sv_outlier_reason |
There was a problem hiding this comment.
Took a stab at removing the redundant combo of str_detect and regex here.
| make_triad_map("North") | ||
| ``` | ||
|
|
||
| ::: |
There was a problem hiding this comment.
Exact same map code as res
wagnerlmichael
requested review from
jeancochrane and
wrridgeway
as code owners
jeancochrane
changed the base branch from
master
to
Update-pipeline-with-outlier-column-changes
jeancochrane
left a comment
jeancochrane
left a comment
There was a problem hiding this comment.
Looks great! I hope it's OK that I took the liberty to run the ingest, push to the DVC remote, and update the hashes in the lockfile here. That way when we merge this, everyone else can use dvc pull to grab the version of the training data that includes nonliveable spaces in sv_outlier_reason.
The error we've been seeing in rendering the performance report is definitely unrelated to this PR, so let's go ahead and merge this in the meantime.
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
* Update lockfiles to ggplot2 v4 * Upgrade plotly to 4.11.0 to see if it has better support for latest ggplot * Make sure to ungroup outlier ratio comparison before computing range in `_outliers.qmd`
jeancochrane
left a comment
jeancochrane
left a comment
There was a problem hiding this comment.
Great work, sorry this was so much trouble to test due to #133!
2 participants
Same as the res pipeline change
This PR reworks the performance report to work with out new sales val data model additions and add two things to the report:
It also reorganizes the outlier reasons that are displayed
Closes ccao-data/model-res-avm#426.