-
Notifications
You must be signed in to change notification settings - Fork 15
Desk Review Spreadsheet Modifications #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Desk Review Spreadsheet Modifications #434
Conversation
…ling' of github.com:ccao-data/model-res-avm into 418-small-changes-to-desk-review-workbook-for-2026-modeling
| )) %>% | ||
| ungroup() %>% | ||
| # Add flag for PINs which have aforementioned tieback cycles | ||
| left_join(flag_proration_tieback_cycle, by = "meta_pin") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This join actually results in slightly less TRUE observations since the proration cycles count PINs which don't exist as being in a tieback cycle. See the example in the PR comment for an example.
| n_distinct(meta_tieback_key_pin) > 1 | ||
| ) %>% | ||
| ungroup() %>% | ||
| select(meta_pin, flag_proration_tieback_cycle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no duplicates for pin at the moment, but would we want to add a distinct at the end just to make sure it stays that way?
| filter(!is.na(pred_pin_final_fmv_land)) %>% | ||
| mutate(across(ends_with("_date"), as_date)) | ||
|
|
||
| if (comp_enable) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have the comp sheet in the desk review spreadsheet anymore.
pipeline/07-export.R
Outdated
| mutate( | ||
| total_av = glue::glue("=S{row_id} * 0.1"), | ||
| av_difference = glue::glue("=(S{row_id} * 0.1) - (L{row_id} * 0.1)") | ||
| total_av = glue::glue("=S{row_id}"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch to market rather than assessed values
| glue, | ||
| hardhat, | ||
| here, | ||
| igraph, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add igraph to the depends section of the DESCRIPTION. It seems to already be installed in renv, but let me know if not.
|
Do we want to expand this from tieback cycles to also include irregular tieback pins? At the moment we also reference tiebacks which don't exist as an actual PIN, and NA tiebacks. The graph treats NA's as a unique observation so it groups it as >1. I'm pretty sure we can filter NA's out to make this strictly tieback cycles, but let me know what you want. |
…ling' of github.com:ccao-data/model-res-avm into 418-small-changes-to-desk-review-workbook-for-2026-modeling
2026-02-05-footloose-robis the model run which relates to the stage 2 changes.Two other oddities were discovered when looking at tieback cycles. First, there are some pins which have NA tiebacks and are part of a hypothetical tieback cycle.
And there are pins which go to tiebacks which do not have a valid pin
It also removes all references to comps from the desk review spreadsheets.
Completes the following requested tasks.
First, sort by neighborhood number ascending
Within each neighborhood, sort by class code ascending